SDKv2 Diff tests for Defaults in sets and lists #2838
Merged
+6,426
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2838 +/- ##
==========================================
- Coverage 67.48% 67.48% -0.01%
==========================================
Files 325 325
Lines 41633 41633
==========================================
- Hits 28097 28094 -3
- Misses 11957 11959 +2
- Partials 1579 1580 +1 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
force-pushed
the
refactor-set-and-list-diff-tests
branch
from
99e4bf3 to
97056b8
Compare
VenelinMartinov
force-pushed
the
sdkv2-diff-tests-for-defaults-in
branch
from
6b7362c to
89d71db
Compare
VenelinMartinov
force-pushed
the
refactor-set-and-list-diff-tests
branch
from
97056b8 to
f73e706
Compare
VenelinMartinov
force-pushed
the
sdkv2-diff-tests-for-defaults-in
branch
from
89d71db to
188a68d
Compare
VenelinMartinov
force-pushed
the
refactor-set-and-list-diff-tests
branch
from
f73e706 to
b961383
Compare
VenelinMartinov
force-pushed
the
sdkv2-diff-tests-for-defaults-in
branch
from
188a68d to
5ab203a
Compare
iwahbe
approved these changes
Jan 17, 2025
VenelinMartinov
force-pushed
the
sdkv2-diff-tests-for-defaults-in
branch
from
5ab203a to
1dcbb01
Compare
Contributor
|
This PR has been shipped in release v3.102.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Diff tests for Defaults in Set and List schemas. Note that the List and Set themselves can not have Defaults, since TF throws an error on these:
Default is not valid for lists or sets.Related to #2788
Related to #2789